fallintoplace opened a new pull request, #1258: URL: https://github.com/apache/iceberg-go/pull/1258
Summary - stop reading from AllManifests' error channel after it closes cleanly - keep the early-exit drain from blocking once that channel has been disabled - add a regression that drains manifests from several snapshots after the clean close path has happened Why A closed error channel is always ready. When it closed without an error, the select loop could keep taking the nil error case instead of draining ready manifest results. Testing - go test ./table -run '^TestAllManifestsCompletesAfterErrorChannelCloses$' -count=1 - go test ./table -count=1 - go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run --timeout=10m ./table/... - git diff --check - go test ./... -count=1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
