abnobdoss opened a new pull request, #1264:
URL: https://github.com/apache/iceberg-go/pull/1264
Closes #1261
## What
Set `runs-on: ${{ matrix.os }}` so the matrix actually selects runners, and
turn on macOS alongside Linux. `windows-latest` stays commented out until the
path issues in #1262 are sorted. Also add `*.go text eol=lf` to
`.gitattributes` so gofmt passes when Go files are checked out on a non-Linux
runner.
## Why
`runs-on:` was hardcoded to `ubuntu-latest` while `name:` used `${{
matrix.os }}`, so the `os` axis had no effect and every job ran on Linux. macOS
was listed but never actually tested. Making the matrix real gets macOS covered
now. Windows needs filesystem-path fixes first (#1262), so it stays off for the
moment. The `.gitattributes` rule keeps the gofmt linter from failing if a
runner checks out Go sources with CRLF.
## Validation
Tested in a fork: the macOS cells ran lint, tests, and the race job green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
