Copilot commented on code in PR #16665:
URL: https://github.com/apache/iceberg/pull/16665#discussion_r3456559799
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatch.java:
##########
@@ -177,9 +186,16 @@ private boolean
supportsParquetBatchReads(Types.NestedField field) {
// - all tasks are of type FileScanTask and read only ORC files with no
delete files
private boolean useOrcBatchReads() {
Review Comment:
The ORC batch-read conditions comment is now outdated: `useOrcBatchReads()`
also checks projected columns via
`projection.columns().stream().allMatch(this::supportsOrcBatchReads)` to
disable vectorization when `time` is projected. Updating the comment will
prevent future regressions/misunderstanding of when ORC vectorization is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
