plusplusjiajia commented on code in PR #719:
URL: https://github.com/apache/iceberg-cpp/pull/719#discussion_r3458130637
##########
src/iceberg/catalog/rest/rest_catalog.cc:
##########
@@ -878,7 +892,8 @@ Result<std::shared_ptr<Table>>
RestCatalog::MakeTableFromCommitResponse(
// TODO(gangwu): If the REST commit response grows table config or
// storage credentials, derive a replacement table session/FileIO from that
// response. The current table commit response does not define config.
- ICEBERG_ASSIGN_OR_RAISE(auto table_io, TableFileIO(context, table_config));
+ ICEBERG_ASSIGN_OR_RAISE(auto table_io,
+ TableFileIO(context, table_config,
/*storage_credentials=*/{}));
Review Comment:
@wgtmac Fixed. MakeTableFromCommitResponse now reuses the FileIO bound at
load (threaded through TableScopedCatalog) instead of rebuilding it with an
empty credential list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
