abnobdoss commented on code in PR #3551:
URL: https://github.com/apache/iceberg-python/pull/3551#discussion_r3459838068
##########
pyiceberg/table/metadata.py:
##########
Review Comment:
Does this need to change?
##########
pyiceberg/table/metadata.py:
##########
@@ -574,9 +574,6 @@ def construct_refs(self) -> TableMetadata:
next_row_id: int | None = Field(alias="next-row-id", default=None)
"""A long higher than all assigned row IDs; the next snapshot's
`first-row-id`."""
- def model_dump_json(self, exclude_none: bool = True, exclude: Any | None =
None, by_alias: bool = True, **kwargs: Any) -> str:
Review Comment:
Is row lineage fully wired up? If I'm not mistaken, row lineage would be a
pre-requisite for v3 enablement?
##########
pyiceberg/table/metadata.py:
##########
Review Comment:
Does this PR only allow new v3 tables or does it also enable v1/v2 tables to
be upgraded to v3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
