pvary commented on code in PR #16079:
URL: https://github.com/apache/iceberg/pull/16079#discussion_r3461279858
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -426,7 +427,17 @@ public void createTable(ObjectPath tablePath,
CatalogBaseTable table, boolean ig
+ "create table without 'connector'='iceberg' related properties
in an iceberg table.");
}
- Preconditions.checkArgument(table instanceof ResolvedCatalogTable, "table
should be resolved");
+ if (table instanceof CatalogMaterializedTable) {
+ throw new UnsupportedOperationException(
+ "Materialized tables are not supported by Iceberg's Flink catalog.");
+ }
Review Comment:
It was a long time ago when we last discussed this, but do we really need a
dedicated instanceof CatalogMaterializedTable check here?
Wouldn't the generic check below handle the situation correctly and provide
users with enough information to understand and fix the issue on their side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
