laskoviymishka opened a new issue, #1275:
URL: https://github.com/apache/iceberg-go/issues/1275

   Follow-up to #1045.
   
   `splitLineageMetadataFields` has a `caseSensitive == false` branch that 
matches `_row_id` / `_last_updated_sequence_number` via `strings.EqualFold`, 
but every `Scan` in the table tests sets `caseSensitive: true`, so that branch 
runs in no test. The `caseSensitive: false` subtest the reviewer asked for was 
never added.
   
   Add a table-driven test that calls `splitLineageMetadataFields` directly 
with `caseSensitive=false` and mixed-case names (`_ROW_ID`, 
`_Last_Updated_Sequence_Number`), asserting they land in the lineage fields, 
with a `caseSensitive=true` control asserting the same names fall through to 
user fields.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to