laskoviymishka opened a new issue, #1271: URL: https://github.com/apache/iceberg-go/issues/1271
Follow-up to #984. `TestGeographyType` and the geo schema round-trips assert with `assert.JSONEq`, which is key-order- and whitespace-agnostic — so nothing pins the byte-exact type-string emission that other Iceberg clients have to parse. The only geo fixtures we ship are the Parquet files under `table/testdata/geo/` from `apache/parquet-testing`, and those exercise the Parquet read path, not the Iceberg geo type-string JSON. Add a fixture test that loads a Java/PyIceberg-emitted schema JSON with a `geography` field carrying a non-default CRS + algorithm (e.g. `geography(srid:4269, karney)`) and a `geometry` field with a custom CRS, unmarshal/re-marshal it, and compare the emitted type string byte-for-byte — not `JSONEq` — against the checked-in fixture. Document the producing implementation and version on the fixture, the way `puffin/dv_golden_test.go` does for the DV blob. Locking the wire format before more geo PRs build on it is newcomer-sized: no domain depth, clear pass/fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
