C-Loftus opened a new pull request, #1280: URL: https://github.com/apache/iceberg-go/pull/1280
Following up on https://github.com/apache/iceberg-go/pull/1268 as next step for https://github.com/apache/iceberg-go/issues/1096 The previous PR mistakenly specified `filesystem: icebergio.LocalFS{},` so the hadoop catalog will continue to only use the local filesystem which is incorrect. - I moved the path normalization into an if statement to only do path cleanups if the uri is local. Otherwise for schemes like `s3://` it will use it directly as the client provides it. - I added a type check to see if the filesystem implements the `HadoopCatalogFS` interface. This is dynamic since we presumably want to support external users creating their own implementations if needed and loading them via `io.LoadFS`. We could of course also change the `NewCatalog` function to directly take in a filesystem which fulfils the interface but I assumed we didn't want to edit the constructor in that way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
