nanookclaw opened a new pull request, #1282: URL: https://github.com/apache/iceberg-go/pull/1282
`Properties.GetInt` parses with `strconv.ParseInt(v, 10, 64)` then narrows to platform-width `int`. On 32-bit targets `math.MaxInt` is `MaxInt32` (~25 days in ms), so the "keep everything" sentinel for `MaxSnapshotAgeMsDefault` and `MaxRefAgeMsDefault` collapses before the `int64()` widening in `ExpireSnapshots` — snapshots or refs older than ~25 days get expired even when no retention was configured. **Fix:** Add `Properties.GetInt64(key string, defVal int64) int64` that returns the full `int64` without platform truncation, retype the two age defaults to `int64(math.MaxInt64)`, and update `ExpireSnapshots` to use `GetInt64` for those properties. `MinSnapshotsToKeepDefault` remains `math.MaxInt` with `GetInt` because its downstream type is `int`, not `int64`. Closes #1278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
