parthchandra commented on PR #2668: URL: https://github.com/apache/iceberg-rust/pull/2668#issuecomment-4783305963
> Comet generates the FileScanTasks from Iceberg Java. Does Iceberg Java provide `unified_partition_type`, otherwise we need to be sure Comet can generate these if you want Comet to work with this. Good point! Iceberg Java doesn't provide unified_partition_type on individual FileScanTasks — Java computes it at a higher level via [Partitioning.partitionType(table) ](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/Partitioning.java#L240-L244) We can do the equivalent in Comet - https://github.com/parthchandra/datafusion-comet/blob/iceberg-metadata-columns/native/core/src/execution/planner.rs#L3409-L3440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
