fallintoplace opened a new pull request, #1290:
URL: https://github.com/apache/iceberg-go/pull/1290

   Summary
   
   - release zero-row record batches before createIterator skips them
   - add a checked-allocator regression using a zero-row slice that still owns 
Arrow buffers
   
   Why
   
   createIterator owns each batch it reads from the sequenced channel. 
Non-empty batches are handed to the caller, but empty batches were skipped with 
continue and never released. That could leak Arrow buffers when filters/deletes 
produce zero-row batches.
   
   Testing
   
   - go test ./table -run '^TestCreateIteratorReleasesEmptyRecordBatches$' 
-count=1
   - go test ./table -count=1
   - git diff --check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to