fallintoplace opened a new pull request, #1291: URL: https://github.com/apache/iceberg-go/pull/1291
Summary - clone caller-provided catalog properties before filling config defaults - keep the merged properties passed to the selected catalog registrar - add a regression that proves the original props map is unchanged Why catalog.Load fills default uri, credential, and warehouse values from the configured catalog. When callers passed a non-nil properties map, those defaults were written back into the caller-owned map. That made Load have surprising side effects and could leak defaults into later loads when a map was reused. Testing - go test ./catalog -run '^TestCatalogLoadDoesNotMutateProps$' -count=1 - go test ./catalog -count=1 - git diff --check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
