rdblue commented on a change in pull request #1948:
URL: https://github.com/apache/iceberg/pull/1948#discussion_r546004567
##########
File path:
spark3-extensions/src/main/scala/org/apache/iceberg/spark/extensions/IcebergSparkSessionExtensions.scala
##########
@@ -37,6 +37,6 @@ class IcebergSparkSessionExtensions extends
(SparkSessionExtensions => Unit) {
// TODO: PullupCorrelatedPredicates should handle row-level operations
extensions.injectOptimizerRule { _ =>
PullupCorrelatedPredicatesInRowLevelOperations }
extensions.injectOptimizerRule { _ => RewriteDelete }
- extensions.injectPlannerStrategy { _ => ExtendedDataSourceV2Strategy }
+ extensions.injectPlannerStrategy { spark =>
ExtendedDataSourceV2Strategy(spark) }
Review comment:
This follows what we do above, and it seemed reasonably clean to me. I
guess we could just pass `ExtendedDataSourceV2Strategy` and have apply
automatically called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
