stevenzwu commented on code in PR #16769:
URL: https://github.com/apache/iceberg/pull/16769#discussion_r3463674744
##########
core/src/main/java/org/apache/iceberg/DeletionVectorStruct.java:
##########
@@ -128,6 +129,26 @@ static Builder builder() {
return new Builder();
}
+ @Override
+ public boolean equals(Object other) {
Review Comment:
@rdblue the comparison was introduced due to my comment
[here](https://github.com/apache/iceberg/pull/16769#discussion_r3422893663). Do
you think it is sth we should guard against? if not, we can maybe just add
Javadoc to explain the usage. if yes, should we just do a reference comparison
like `this.deletionVector != newDeletionVector` or we want a util method like
`DelectionVectorUtil.sameContents(DeletionVector, DeletionVector)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
