shangxinli commented on PR #776: URL: https://github.com/apache/iceberg-cpp/pull/776#issuecomment-4784804944
Codex re-review confirmed P0/P3 resolved and flagged a P2: `Validate()` was using `AlwaysTrue` for both conflict checks, which would spuriously reject concurrent writes to unrelated partitions (Java scopes them to the overwritten partition set). Force-pushed a fix: track touched partitions in a `PartitionSet` during `AddFile()` and pass it to the `ValidateAddedDataFiles` / `ValidateNoNewDeleteFiles` partition-set overloads. Falls back to `AlwaysTrue` only for unpartitioned tables, where every concurrent write is by definition a conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
