zhongyujiang commented on code in PR #16929:
URL: https://github.com/apache/iceberg/pull/16929#discussion_r3464078101
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/source/DataIterator.java:
##########
@@ -103,9 +104,6 @@ public void seek(int startingFileOffset, long
startingRecordOffset) {
combinedTask));
}
}
-
- fileOffset = startingFileOffset;
- recordOffset = startingRecordOffset;
Review Comment:
The `recordOffset` assignment is unnecessary here because `next()` already
increments `recordOffset` correctly during the skip-records loop above, so it
naturally reaches the correct value by the end of the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
