sandugood commented on code in PR #2693:
URL: https://github.com/apache/iceberg-rust/pull/2693#discussion_r3465590062
##########
crates/iceberg/src/arrow/reader/pipeline.rs:
##########
@@ -337,13 +337,13 @@ impl FileScanTaskReader {
}
if self.row_selection_enabled {
- row_selection =
Some(ArrowReader::get_row_selection_for_filter_predicate(
+ row_selection =
ArrowReader::get_row_selection_for_filter_predicate(
Review Comment:
Added a full-suite test that address:
- writing with disabled stats (so, now col/offset index available on read)
and reading it with a predicate
- writing a position delete file along the previously written `.parquet` and
reading it with a predicate
Both cases address the change introduced by the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
