RussellSpitzer commented on a change in pull request #1955:
URL: https://github.com/apache/iceberg/pull/1955#discussion_r546033284



##########
File path: core/src/main/java/org/apache/iceberg/avro/BuildAvroProjection.java
##########
@@ -96,7 +96,7 @@ public Schema record(Schema record, List<String> names, 
Iterable<Schema.Field> s
 
       } else {
         Preconditions.checkArgument(
-            field.isOptional() || field.fieldId() == 
MetadataColumns.ROW_POSITION.fieldId(),
+            field.isOptional() || 
MetadataColumns.metadataFieldIds().contains(field.fieldId()),

Review comment:
       This reminds me we need to fix that projection bug / selection bug




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to