fallintoplace opened a new pull request, #1308: URL: https://github.com/apache/iceberg-go/pull/1308
Summary - parse bucket and truncate transforms with exact syntax checks - reject bogus transform names like bucketx[5] and truncatefoo[10] - add negative parser coverage for invalid bucket/truncate prefixes Why ParseTransform used prefix checks for bucket and truncate before applying a generic bracket parser. That let strings with extra transform-name text parse as valid parameterized transforms. The parser now only accepts the Iceberg transform forms bucket[N] and truncate[N]. Testing - go test . -run '^TestParseTransform$' -count=1 - go test . -count=1 - go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run --timeout=10m . - git diff --check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
