zeroshade commented on code in PR #1303:
URL: https://github.com/apache/iceberg-go/pull/1303#discussion_r3470059668
##########
table/equality_delete_reader.go:
##########
@@ -65,6 +65,10 @@ func readAllEqualityDeleteFiles(ctx context.Context, fs
iceio.IO, schema *iceber
continue
}
+ if len(d.EqualityFieldIDs()) == 0 {
+ return nil, fmt.Errorf("equality delete file %s
has no equality field IDs", d.FilePath())
Review Comment:
Non-blocking: the writer side exposes `table.ErrEmptyEqualityFieldIDs`
(equality_delete_writer.go) and its tests assert it via `errors.Is`. Consider
wrapping that sentinel here so callers can match programmatically:
`fmt.Errorf("%w: equality delete file %s", ErrEmptyEqualityFieldIDs,
d.FilePath())` (or `iceberg.ErrInvalidSchema`, which the writer uses for its
related field-ID validation). The reader's sibling error just below ("field ID
not found") is also a plain error, so this is consistency polish rather than a
defect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
