fallintoplace opened a new pull request, #1310: URL: https://github.com/apache/iceberg-go/pull/1310
Summary - create missing parent directories in LocalFS.WriteFile before writing - cover nested plain paths and file:// paths Why LocalFS.Create already creates parent directories, but WriteFile called os.WriteFile directly. Code paths that write generated nested locations through WriteFile could fail locally even though the matching Create path succeeds. Testing - go test ./io -run '^TestLocalFSWriteFileCreatesParentDirectories$' -count=1 - go test ./io -count=1 - go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run --timeout=10m ./io - git diff --check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
