Revanth14 commented on code in PR #1239:
URL: https://github.com/apache/iceberg-go/pull/1239#discussion_r3470986503
##########
table/arrow_utils_internal_test.go:
##########
@@ -491,3 +492,128 @@ func TestIcebergCRSToGeoArrowMetadata(t *testing.T) {
assert.Empty(t, meta.CRSType)
})
}
+
+func TestGeoArrowCRSToIcebergCRS(t *testing.T) {
+ stringCRS := func(s string) json.RawMessage {
Review Comment:
I removed the defensive `require.NoError` from `stringCRS` and now ignore
the marshal error with a short `nolint` comment, since marshaling a string
cannot fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
