prafulla-kiran commented on PR #1269: URL: https://github.com/apache/iceberg-go/pull/1269#issuecomment-4798616234
Thanks for the close read, @laskoviymishka — both points are fair. **Test reshaped.** Force-pushed an amend that pivots the iceberg sub-cases onto the success path, mirroring `TestGlueGetTableCaseInsensitive`. The test now writes a minimal valid v2 metadata document to `t.TempDir()`, sets `metadata_location` to a `file://` URI, and asserts `NoError` + a non-nil `*table.Table` with the right identifier for `ICEBERG` / `iceberg` / `IcEbErG`. The `HIVE` case keeps the `is not an iceberg table` substring check. Confirmed the test fails on the lowercase sub-case if the `!=` is restored, so it now pins the type-check behavior directly rather than leaning on a downstream error message. **`EXTERNAL_TABLE` follow-up.** Agreed that's a separate concern and worth its own issue — I'll keep this PR scoped to the `convertGlueToIceberg` regression and file a follow-up for the `TableType` check after this lands. (PyIceberg's behavior aligns with what you suggested: it doesn't enforce `EXTERNAL_TABLE` at all, so Glue native Iceberg REST-registered tables are accepted there.) Re-requesting review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
