JeroenSchmidt commented on PR #3529: URL: https://github.com/apache/iceberg-python/pull/3529#issuecomment-4799052099
> Hi @JeroenSchmidt - thanks for contributing this PR! This seems consistent with #2799’s precedent of normalizing Arrow integer input to Iceberg’s canonical signed physical type for write compatibility. > > On the edge case you highlighted: could we add a regression test showing that uint32 values > INT32_MAX fail rather than wrap/truncate? Thank you @sungwy for having a look. I pushed a test that ensures that we get an exception instead of writing wrapped data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
