ebyhr commented on code in PR #16727:
URL: https://github.com/apache/iceberg/pull/16727#discussion_r3478422821
##########
format/udf-spec.md:
##########
@@ -220,6 +228,7 @@ RETURN x + 1.0;
"definitions": [
{
"definition-id": "int",
+ "specific-name": "add_one_int",
Review Comment:
nit: This JSON is located after the Trino and Spark SQL examples. Since it
doesn't include a SPECIFIC clause, readers may wonder where "specific-name":
"add_one_int" comes from.
Does Spark support the SPECIFIC clause? If it does, we could add it to the
SQL example.
It's unsupported as far as I checked
https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-create-sql-function.html
though.
I know Trino doesn't support it. I'll bring this issue to the attention of
the Trino community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
