john801205 opened a new pull request, #16970:
URL: https://github.com/apache/iceberg/pull/16970

   ### Summary 
   The rewrite data files action reported commit failures even when every 
commit succeeded. It inferred the failure count by subtracting succeeded 
commits from min(totalGroupCount, maxCommits), but the actual number of commits 
is ceil(totalGroupCount / groupsPerCommit), which is usually smaller. This 
over-counted failures and triggered spurious warnings or errors.
   
   Track failed commits directly in BaseCommitService via an AtomicInteger 
(incremented in the commit catch block), make succeededCommits atomic as well 
since commits run on the multi-threaded rewrite pool, and have the Spark action 
read failedCommits() instead of computing it by subtraction.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to