jhrotko commented on PR #16780: URL: https://github.com/apache/iceberg/pull/16780#issuecomment-4811834254
> For consolidation: https://github.com/apache/iceberg/pull/16757 (open, also Closes https://github.com/apache/iceberg/issues/16744) implements the same feature with the same design - classify the retry-exhaustion reason in Tasks and translate it into commit.retry.* guidance at the call sites. Neither PR references the other; worth maintainers picking one direction before either merges. @wombatu-kun Thanks for pointing this out. I agree these two PRs overlap and it would be good to consolidate before either moves forward. I took a closer look at both approaches. My current preference is to continue with this PR because it keeps retry exhaustion handling opt in within Tasks, keeps commit specific translation at the commit call sites, and now covers the BaseTransaction retry paths as well. That said, I am happy to defer to maintainers on which direction they prefer. If there is agreement, I can help link the PRs and carry over anything useful from the other one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
