yadavay-amzn commented on PR #16235: URL: https://github.com/apache/iceberg/pull/16235#issuecomment-4812139314
Thanks all - reworked the instantiation: `s3.metrics-publisher-impl` now points to a small `S3MetricPublisherProvider` factory (no-arg ctor + `initialize(Map)` + `metricPublisher()`), loaded via `DynConstructors` like `AwsClientFactory`, so it works with every SDK publisher including builder-only EMF (@danielcweeks's point). Also folded in the plural rename (@wombatu-kun), the specific-exception assertions and the SDK javadoc link (@singhpk234), and kept the override-config preservation + CRT caveat. PTAL - and thanks @dannycjones for the look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
