Revanth14 commented on PR #1324: URL: https://github.com/apache/iceberg-go/pull/1324#issuecomment-4812171208
> A couple of non-blocking documentation nits from the scan-planning client methods (comment-only, not requesting changes; the low-level surface looks spec-compliant otherwise): > > **Stale file header - `catalog/rest/scan_planning.go` lines 17-24:** the top-of-file comment still says the method bodies are intentionally unimplemented stubs (returning `ErrNotImplemented`) and that endpoint capability discovery lands separately in the Phase 0 PR. This PR implements `PlanTableScan` / `FetchPlanningResult` / `CancelPlanning` / `FetchScanTasks` plus the `Supports*` capability checks, so that header is now stale and worth updating or removing. (Noting it here rather than inline because those lines aren't part of the diff.) Updated the stale scan_planning.go file header to reflect the implemented low-level client methods and remaining follow-up scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
