fallintoplace opened a new pull request, #1330:
URL: https://github.com/apache/iceberg-go/pull/1330
Summary
parse the REST catalog `token` property into the static OAuth token option
preserve that static token in the catalog's retained properties
add regression coverage for helper parsing/serialization and the
`catalog.Load(..., {"token": ...})` auth path
Why
The REST catalog already defines `token` as a first-class property key, and
`WithOAuthToken` correctly wires a static bearer token into authentication. But
the property path was incomplete: `fromProps` ignored `token`, so
`catalog.Load` silently skipped static-token auth, and `toProps` dropped it
from the catalog's retained properties.
This made property-driven REST catalog auth behave differently from the
explicit option path.
Testing
go test ./catalog/rest -run
'Test(ToPropsSigv4RegionFallback|FromPropsReadsOAuthToken|TokenAuthenticationPriority|RestTLSCatalogSuite)$'
-count=1
go test ./catalog/rest -count=1
go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run
--timeout=10m ./catalog/rest/...
git diff --check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
