fallintoplace opened a new pull request, #1334: URL: https://github.com/apache/iceberg-go/pull/1334
Summary format manifest-list header snapshot ids, sequence numbers, parent snapshot ids, and first-row ids directly from int64 remove the intermediate `int` conversion in V1/V2/V3 manifest list writers add regression coverage that reads the OCF header metadata back for large 64-bit values Why The manifest-list writers were serializing several 64-bit metadata fields by converting them to `int` and then calling `strconv.Itoa`. That is conceptually wrong for Iceberg's 64-bit ids and unsafe on 32-bit builds. Using `strconv.FormatInt(..., 10)` keeps the full value intact for snapshot ids, sequence numbers, parent snapshot ids, and v3 first-row ids. Testing go test . -run 'TestManifests/TestManifestListWriterMetadataPreservesInt64Values$' -count=1 go test . -count=1 go test ./table -count=1 go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run --timeout=10m . ./table/... git diff --check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
