fallintoplace opened a new pull request, #1337: URL: https://github.com/apache/iceberg-go/pull/1337
Summary - replace unchecked positional-delete `pos` casts with a shared validated collector - return `ErrInvalidSchema` when a delete file exposes a non-`int64` `pos` chunk - add regression coverage for malformed `pos` chunk types Why The Arrow scanner assumed every positional-delete `pos` chunk was `*array.Int64` and cast it directly in both scan paths. If a malformed delete file carried the wrong Arrow type, the scanner panicked instead of returning a schema error. Testing - `go test ./table -run 'Test(GroupPosDeletesByFilePathSupportsStringLayouts|GroupPosDeletesByFilePathRejectsUnsupportedFilePathLayout|CollectPosDeletePositionsRejectsUnsupportedPosType|ProcessPositionalDeletesAcrossBatches)$' -count=1` - `go test ./table -count=1` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
