kevinjqliu commented on code in PR #2692:
URL: https://github.com/apache/iceberg-rust/pull/2692#discussion_r3489328042
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -347,6 +348,10 @@ struct RestContext {
///
/// It's could be different from the user config.
config: RestCatalogConfig,
+ /// Endpoints the server advertised in its `GET /v1/config` response, used
+ /// for capability negotiation. Empty when the server does not advertise an
Review Comment:
I think we should treat an explicit empty `endpoints` list the same as an
absent one and fall back to `DEFAULT_ENDPOINTS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
