rdblue commented on a change in pull request #1955:
URL: https://github.com/apache/iceberg/pull/1955#discussion_r546838823
##########
File path:
spark3-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java
##########
@@ -48,32 +48,32 @@ public SparkRowLevelOperationsTestBase(String catalogName,
String implementation
@Parameters(name = "catalogName = {0}, implementation = {1}, config = {2},
format = {3}, vectorized = {4}")
public static Object[][] parameters() {
return new Object[][] {
- { "testhive", SparkCatalog.class.getName(),
- ImmutableMap.of(
- "type", "hive",
- "default-namespace", "default"
- ),
- "orc",
- true
- },
+// { "testhive", SparkCatalog.class.getName(),
+// ImmutableMap.of(
+// "type", "hive",
+// "default-namespace", "default"
Review comment:
Yes, will remove. Sorry about that, I usually look through the PR to
catch these before review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
