gaborkaszab commented on PR #16285: URL: https://github.com/apache/iceberg/pull/16285#issuecomment-4833424093
Pushed a new change set with the following changes: - Rebased with main to resolve conflicts - Adjust error messages in `TrackedFileBuilder` (to follow other messages we adjusted in other PSs for the builder) - Removed override for `equals()` method in `ColumnFile` (learned in other PRs that we try to avoid such overrides) - Implemented a check in `TrackedFileBuilder.columnFiles()` to verify that we don't add the same column files. Check is based on location of the column files - Realized that column files are allowed even for manifests, but there was a check in `TrackingBuilder` to not allow column files together with deleted/replaced positions. Removed this check and the relevant tests, also added new tests to verify they are allowed together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
