rdblue commented on a change in pull request #1933:
URL: https://github.com/apache/iceberg/pull/1933#discussion_r546858189
##########
File path: site/docs/spark.md
##########
@@ -347,6 +347,28 @@ df.createOrReplaceTempView("table")
spark.sql("""select count(1) from table""").show()
```
+**Note**: Dataframe read options are available as static constants in
[SparkReadOptions](https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/types/SparkReadOptions.java)
class.
+
+| Spark Read option | Constant |
+| --------------- | --------------------- |
+| snapshot-id | SNAPSHOT_ID |
+| as-of-timestamp | AS_OF_TIMESTAMP |
+| split-size | SPLIT_SIZE |
+| lookback | LOOKBACK |
+| file-open-cost | FILE_OPEN_COST |
+| vectorization-enabled | VECTORIZATION_ENABLED |
+| batch-size | VECTORIZATION_BATCH_SIZE |
Review comment:
I'm not sure that we want to encourage users to refer to constants in
Iceberg. What do you think, @aokolnychyi, @holdenk, @RussellSpitzer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
