Revanth14 commented on code in PR #1324:
URL: https://github.com/apache/iceberg-go/pull/1324#discussion_r3496682234
##########
catalog/rest/rest_internal_test.go:
##########
@@ -914,22 +914,22 @@ func TestResponseBodyLeak(t *testing.T) {
baseURI, err := url.Parse(srv.URL)
require.NoError(t, err)
- _, err = do[struct{}](context.Background(), http.MethodGet,
baseURI, []string{"test"}, client, nil, false)
+ _, err = do[struct{}](context.Background(), http.MethodGet,
baseURI, []string{"test"}, client, nil)
Review Comment:
Addressed.
Added direct `sessionTransport.RoundTrip` coverage in
`TestRoundTripDefaultHeaderHandling`. It now verifies:
- a session default is applied when the request lacks the header
- a real per-request header overrides the session default without
appending/duplicating it
- context-carried suppression drops the session default
So the generalized default-header behavior is pinned independently of the
scan-planning request tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
