kszucs commented on code in PR #2561:
URL: https://github.com/apache/iceberg-rust/pull/2561#discussion_r3497725686
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -73,6 +77,34 @@ impl ParquetWriterBuilder {
match_mode,
}
}
+
+ /// Build a `ParquetWriterBuilder` from Iceberg table properties and a
+ /// schema, translating `write.parquet.*` settings into `WriterProperties`
+ /// instead of using parquet-rs defaults.
+ ///
+ /// Currently translates the content-defined-chunking keys
+ /// (`write.parquet.content-defined-chunking.*`); other keys fall back to
+ /// parquet-rs defaults.
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
