amirdeljouyi opened a new pull request, #17020: URL: https://github.com/apache/iceberg/pull/17020
Hey, I added two regression tests for `TableMetadata` replacement behavior. They cover supplied snapshot loading and the metadata replacement path, making sure identifiers, sequence values, defaults, and metadata history are preserved. Impact on coverage: Covered lines include [`TableMetadata.java:432-433`](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/TableMetadata.java#L432-L433), [`TableMetadata.java:546-558`](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/TableMetadata.java#L546-L558), [`TableMetadata.java:718-757`](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/TableMetadata.java#L718-L757), and [`TableMetadata.java:1550-1583`](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/TableMetadata.java#L1550-L1583). Line coverage increases by 3%. Why: These paths were easy to regress without a direct test, so this adds focused coverage without changing production code. Thanks, Amir -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
