RussellSpitzer commented on code in PR #16972:
URL: https://github.com/apache/iceberg/pull/16972#discussion_r3501090976
##########
format/spec.md:
##########
@@ -737,6 +765,7 @@ The `data_file` struct consists of the following fields:
| | _optional_ | _optional_ | **`143 referenced_data_file`**
| `string` |
Fully qualified location (URI with FS scheme) of a data file that all deletes
reference [4] |
| | | _optional_ | **`144 content_offset`**
| `long` |
The offset in the file where the content starts [5] |
| | | _optional_ | **`145 content_size_in_bytes`**
| `long` |
The length of a referenced content stored in the file; required if
`content_offset` is present [5] |
+ | | | _optional_ | **`147 collation_bounds`**
| `map<148: int, 149: list<150: struct<...>>>` |
Map from column id to collation-aware lower/upper bounds for a collated string
column, one entry per collation version present [6]. See
[Collations](#collations) |
Review Comment:
My note above clarifies this, but the reason I don't want this hardcoded
here is that it only applies to strings. The Map type here would mean we have
to load all collations before we figure out if there is a bound we can use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
