dannycjones commented on PR #2715: URL: https://github.com/apache/iceberg-rust/pull/2715#issuecomment-4847498176
> Thanks for working on this! > > What do you think about making `release_python.yml` standalone instead? It doesnt look like theres a need for `release_python.yml` to depend on `publish.yml`. > > As long as both are using the same trigger, both can run independently and we'll produce the same artifacts. > > I believe PyPi is already configured with `release_python.yml`, so no need to change that either (I'll double check this) > > EDIT: yep, pypi is configured with `release_python.yml` already > > > Repository: [apache/iceberg-rust](https://github.com/apache/iceberg-rust) > > Workflow: release_python.yml > > Environment name: pypi I noticed we could do this too. My thinking is that we wouldn't want to release the Python bindings if the crate itself couldn't be released (although perhaps we think the same of the Python bindings too). I'm a little wary since we do not do a publish to crates.io until after RC, so if something goes wrong there, we've already published the Python bindings release. I don't have a strong preference, let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
