laskoviymishka opened a new pull request, #1348:
URL: https://github.com/apache/iceberg-go/pull/1348
Follow-up to #1054. cleanup the next-row-id overflow guard in
validateAndUpdateRowLineage to check overflow before computing the wrapped sum
(added-rows > MaxInt64 - next-row-id) and reword the error to say what actually
happened ("adding N rows to next-row-id M overflows int64") rather than the
misleading "regressed". Document the invariants the guard relies on: added-rows
is non-nil/non-negative and next-row-id is non-negative at that point.
Tests: drop the redundant positive-advance case (covered by
TestAddSnapshotV3UpdatesNextRowID), make the zero-added-rows test falsifiable
by seeding a non-zero cursor first, and add the MaxInt64 accept boundary
alongside the overflow reject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
