wombatu-kun commented on code in PR #17013:
URL: https://github.com/apache/iceberg/pull/17013#discussion_r3502933493
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##########
@@ -60,6 +62,18 @@ public class HadoopTableOperations implements
TableOperations {
private static final TableMetadataParser.Codec[]
TABLE_METADATA_PARSER_CODEC_VALUES =
TableMetadataParser.Codec.values();
+ public static final String VERSION_HINT_NUM_RETRIES =
"iceberg.version-hint.retry.num-retries";
Review Comment:
These four `iceberg.version-hint.retry.*` keys are Hadoop `Configuration`
keys, the same category already centralized in
`org.apache.iceberg.hadoop.ConfigProperties` (`iceberg.engine.hive.enabled`,
`iceberg.hive.keep.stats`). Defining them plus their `_DEFAULT`s on
`HadoopTableOperations`, which otherwise holds no public config constants,
scatters Hadoop config keys across the package; consider moving them to
`ConfigProperties` for discoverability, consistent with AGENTS.md "Config:
`XxxProperties`. Check existing utilities first."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
