u70b3 commented on PR #2723: URL: https://github.com/apache/iceberg-rust/pull/2723#issuecomment-4849868804
@viirya Thanks for the thorough and rigorous review — really appreciate you cross-checking the spec wording and the Java reference implementation. You're right that the duplicate-id and schema-membership checks are deliberate stricter guards. A duplicate equality id is almost certainly a user/configuration error, and an id missing from the schema would lead to a confusing failure later (or a meaningless delete file). Failing fast here with a clear error message feels like the right behavior for the Rust writer. I'll also open a corresponding PR against the Java SDK to add the same duplicate / missing-id validation there, so the two implementations stay aligned on this stricter behavior. I'll link it back to this PR once it's up. Thanks again for the LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
