rdblue commented on code in PR #17022:
URL: https://github.com/apache/iceberg/pull/17022#discussion_r3507179416
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -100,32 +121,40 @@ public static MetricsConfig forTable(Table table) {
return from(table.properties(), table.schema(), table.sortOrder());
}
- /**
- * Creates a metrics config for a position delete file.
- *
- * @param table an Iceberg table
- * @deprecated This method is deprecated as of version 1.11.0 and will be
removed in 1.12.0.
- * Position deletes that include row data are no longer supported. Use
{@link
- * #forPositionDelete()} instead.
- */
- @Deprecated
- public static MetricsConfig forPositionDelete(Table table) {
- ImmutableMap.Builder<String, MetricsMode> columnModes =
ImmutableMap.builder();
+ public Iterable<Integer> metricsFieldIds() {
+ return idToName.keySet();
Review Comment:
No, I think it should fail if `idToName` is null because there could be a
configuration, but the config wasn't initialized the right way. If `idToName`
is null, then it was initialized without a schema, which we want to stop doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
