AnatolyPopov commented on code in PR #16434:
URL: https://github.com/apache/iceberg/pull/16434#discussion_r3511395360
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java:
##########
@@ -235,6 +239,12 @@ private static ConfigDef newConfigDef() {
120000L,
Importance.LOW,
"config to control coordinator executor keep alive time");
+ configDef.define(
+ COMMIT_MAX_CONSECUTIVE_FAILURES_PROP,
+ ConfigDef.Type.INT,
+ COMMIT_MAX_CONSECUTIVE_FAILURES_DEFAULT,
+ Importance.MEDIUM,
+ "Maximum number of consecutive commit failures before the coordinator
terminates");
Review Comment:
I believe `ConfigDef.Range.atLeast(1)` still needs to be addressed or am I
missing anything?
Also the config needs to be added to the docs I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
