thswlsqls opened a new pull request, #17051: URL: https://github.com/apache/iceberg/pull/17051
Closes #17050 ## Summary - `BaseSnapshotDeltaLakeTableAction.getFullFilePath()` joined relative Delta data file paths with `File.separator`, which reflects the client JVM's host OS, not the target filesystem — broken on Windows against S3/GCS/HDFS/local targets. - Matches `core/RewriteTablePathUtil.FILE_SEPARATOR`, which already fixed the identical problem with the same POSIX-separator constant. - Lowered `getFullFilePath` from `private` to package-private so it can be unit-tested directly (class itself is already package-private). - Removed the now-unused `import java.io.File;`. ## Testing done - Added `TestBaseSnapshotDeltaLakeTableAction#getFullFilePathJoinsRelativePathWithPosixSeparator`, `#getFullFilePathReturnsAbsolutePathUnchanged`, `#getFullFilePathDecodesEncodedRelativePath` covering relative-path joining, absolute-path passthrough, and URL-decoded input. - `./gradlew :iceberg-delta-lake:check` — 7 tests passed (0 failures). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
