fallintoplace opened a new pull request, #1383: URL: https://github.com/apache/iceberg-go/pull/1383
## Summary `NestedField.Equals` compared `InitialDefault` and `WriteDefault` with `==`, which can panic when defaults contain non-comparable values (maps/slices/etc). This changes equality to use `reflect.DeepEqual` for defaults so schema/field comparisons stay safe and correct with nested defaults. Also adds a regression test that verifies: - non-comparable defaults no longer panic in `Equals`, and - equivalent deep structures compare equal while different defaults compare false. ## Testing - `go test ./... -run 'TestNestedFieldEqualsWithNonComparableDefaults|TestUnknownTypeInNestedStructs|TestTypesBasic' -count=1` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
