zeroshade commented on PR #1326: URL: https://github.com/apache/iceberg-go/pull/1326#issuecomment-4883184047
Following up after the latest commit: it only addresses the nlreturn lint, so my earlier request-changes still stands. The stale-claim recovery gap is unaddressed — if the process dies between taking the vN.metadata.json.claim and the final publish, that claim permanently blocks the version because the fs.ErrExist branch never checks whether a final metadata file actually exists. Please add the recovery check (on fs.ErrExist, call metadataVersionLocation and reclaim or remove an abandoned claim when no final metadata exists) plus a regression test that leaves a claim without final metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
